Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for spam check #692

Merged
merged 2 commits into from
Oct 22, 2018

Conversation

pyasi
Copy link
Contributor

@pyasi pyasi commented Oct 19, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • This adds simple tests for the spam check class.
  • I'm simply getting my feet wet in this repo and think that writing tests is a good and productive start. Happy to hear feedback!

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 19, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 19, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 19, 2018

Codecov Report

Merging #692 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #692      +/-   ##
==========================================
+ Coverage   84.77%   84.94%   +0.17%     
==========================================
  Files          35       35              
  Lines        1156     1156              
  Branches      172      172              
==========================================
+ Hits          980      982       +2     
  Misses         90       90              
+ Partials       86       84       -2
Impacted Files Coverage Δ
sendgrid/helpers/mail/spam_check.py 96.15% <0%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b68316...0f7e836. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious thinkingserious merged commit 22c5b05 into sendgrid:master Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @pyasi,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@pyasi pyasi deleted the add-tests-for-spam-check branch October 23, 2018 00:21
@thinkingserious
Copy link
Contributor

Hello @pyasi,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@pyasi
Copy link
Contributor Author

pyasi commented Oct 25, 2018

Hey @thinkingserious i’ve put up another PR here #705. It’s been a lot of fun thank you and your team for putting this together!

@thinkingserious
Copy link
Contributor

Hello @pyasi,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants