-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct attribution links formating in CoC #672
Conversation
Codecov Report
@@ Coverage Diff @@
## v4 #672 +/- ##
===========================================
- Coverage 84.35% 35.28% -49.07%
===========================================
Files 36 39 +3
Lines 965 1057 +92
Branches 107 137 +30
===========================================
- Hits 814 373 -441
- Misses 93 658 +565
+ Partials 58 26 -32
Continue to review full report at Codecov.
|
Hello @PyroclasticMayhem, Could you please merge this against our v4 branch? Thank you! With Best Regards, Elmer |
Hello @PyroclasticMayhem, |
@thinkingserious I have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to rebase from the v4 branch, not merging it into your existing branch (which contains everything from master.) Please rebase as such. Thanks!
Hello @PyroclasticMayhem, |
Added windows environment variable setup
Added environmental variable setup in windows
editted "our use cases" link
Make it clear that the link is a redirect to an email and not to any members page or developer team page
Remove link to a position not found and replaced with general link to the careers page.
Fixes #671
Checklist
Short description of what this PR does:
If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.