Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct attribution links formating in CoC #672

Closed
wants to merge 45 commits into from
Closed

Correct attribution links formating in CoC #672

wants to merge 45 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2018

Fixes #671

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Change attribution links into bullet points to match CoC in other Sendgrid repos.

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #672 into v4 will decrease coverage by 49.06%.
The diff coverage is 69.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##               v4     #672       +/-   ##
===========================================
- Coverage   84.35%   35.28%   -49.07%     
===========================================
  Files          36       39        +3     
  Lines         965     1057       +92     
  Branches      107      137       +30     
===========================================
- Hits          814      373      -441     
- Misses         93      658      +565     
+ Partials       58       26       -32
Impacted Files Coverage Δ
sendgrid/sendgrid.py 35.71% <ø> (-50.01%) ⬇️
sendgrid/helpers/mail/personalization.py 0% <0%> (-93.06%) ⬇️
sendgrid/helpers/endpoints/ip/unassigned.py 0% <0%> (ø)
sendgrid/version.py 0% <0%> (ø)
sendgrid/helpers/stats/__init__.py 100% <100%> (ø)
sendgrid/helpers/stats/stats.py 82.19% <82.19%> (ø)
sendgrid/helpers/mail/to_email.py 0% <0%> (-100%) ⬇️
sendgrid/helpers/mail/tracking_settings.py 0% <0%> (-96.97%) ⬇️
sendgrid/helpers/mail/substitution.py 0% <0%> (-94.12%) ⬇️
sendgrid/helpers/mail/section.py 0% <0%> (-94.12%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...2cc7d42. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
@thinkingserious
Copy link
Contributor

Hello @PyroclasticMayhem,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @PyroclasticMayhem,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@ghost ghost changed the base branch from master to v4 October 23, 2018 21:37
@ghost
Copy link
Author

ghost commented Oct 23, 2018

@thinkingserious I have made the requested changes.

Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to rebase from the v4 branch, not merging it into your existing branch (which contains everything from master.) Please rebase as such. Thanks!

@thinkingserious
Copy link
Contributor

Hello @PyroclasticMayhem,

Thanks again for the PR!

We noticed that you have earned 2 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@ghost ghost closed this Oct 28, 2018
@ghost ghost deleted the patch-2 branch October 28, 2018 00:09
@ghost ghost mentioned this pull request Oct 28, 2018
6 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.