Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed links in examples #669

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Conversation

pktrieu
Copy link
Contributor

@pktrieu pktrieu commented Oct 11, 2018

Links in examples now point to correct page

Fixes

Checklist

  • [ X] I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ X] I have read the [Contribution Guide] and my PR follows them.
  • [ X] I updated my branch with the master branch.
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added necessary documentation about the functionality in the appropriate .md file
  • [ x] I have added in line documentation to the code I modified

Short description of what this PR does:

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

Links in examples now point to correct page
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 11, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

Merging #669 into master will increase coverage by 2.5%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #669     +/-   ##
=========================================
+ Coverage   79.91%   82.41%   +2.5%     
=========================================
  Files          70       70             
  Lines        2016     2303    +287     
  Branches      338      338             
=========================================
+ Hits         1611     1898    +287     
  Misses        206      206             
  Partials      199      199
Impacted Files Coverage Δ
sendgrid/helpers/inbound/send.py 93.93% <0%> (+0.18%) ⬆️
sendgrid/helpers/inbound/config.py 97.5% <0%> (+0.44%) ⬆️
sendgrid/helpers/mail/spam_check.py 95.45% <0%> (+0.71%) ⬆️
sendgrid/sendgrid.py 83.33% <0%> (+0.72%) ⬆️
sendgrid/helpers/mail/ganalytics.py 96.82% <0%> (+0.74%) ⬆️
sendgrid/helpers/mail/email.py 93.4% <0%> (+0.81%) ⬆️
sendgrid/helpers/mail/subject.py 95.65% <0%> (+0.91%) ⬆️
sendgrid/helpers/mail/groups_to_display.py 93.33% <0%> (+1.02%) ⬆️
sendgrid/helpers/mail/template_id.py 92.3% <0%> (+1.39%) ⬆️
sendgrid/helpers/mail/bcc_settings_email.py 92.3% <0%> (+1.39%) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499c5f1...18e70c1. Read the comment docs.

@agnesjang98 agnesjang98 added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Oct 11, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 19, 2018
Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase against latest master and re-push. Thanks!

@thinkingserious
Copy link
Contributor

@pktrieu could you please take a moment to sign our CLA so that we can merge this?

Also, could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @pktrieu,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @pktrieu,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @pktrieu,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@childish-sambino childish-sambino changed the title Fixed links in examples docs: Fixed links in examples Mar 6, 2020
@childish-sambino childish-sambino merged commit a8c5112 into sendgrid:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants