Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update USAGE.md #655

Merged
merged 1 commit into from
Jan 24, 2019
Merged

Update USAGE.md #655

merged 1 commit into from
Jan 24, 2019

Conversation

chatpion
Copy link
Contributor

@chatpion chatpion commented Oct 8, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Replace all "print x" into "print(x)" to remain consistent with readme.md

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 8, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 8, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #655 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #655   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files          36       36           
  Lines         965      965           
  Branches      107      107           
=======================================
  Hits          814      814           
  Misses         93       93           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd02e4...5049c53. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@thinkingserious thinkingserious added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: waiting for feedback waiting for feedback from the submitter and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @chatpion,

Could you please merge this against our v4 branch? Thank you!

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

Hello @chatpion,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@chatpion chatpion changed the base branch from master to v4 October 23, 2018 19:02
@thinkingserious
Copy link
Contributor

Hello @chatpion,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@chatpion
Copy link
Contributor Author

Should I rebase on top of v4 branch to remove conflicts ?

Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chatpion please rebase against the v4 branch instead of merging master into your branch. This PR now includes all the history from the master branch, which we don't want. Thanks!

Change all "print a" to "print(a)"
@thinkingserious thinkingserious merged commit f17f5d8 into sendgrid:v4 Jan 24, 2019
@thinkingserious
Copy link
Contributor

Hello @chatpion,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: waiting for feedback waiting for feedback from the submitter type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants