-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance to style standards #654
Conformance to style standards #654
Conversation
Added windows environment variable setup
Added environmental variable setup in windows
Codecov Report
@@ Coverage Diff @@
## v4 #654 +/- ##
==========================================
+ Coverage 84.35% 84.77% +0.42%
==========================================
Files 36 35 -1
Lines 965 1156 +191
Branches 107 172 +65
==========================================
+ Hits 814 980 +166
+ Misses 93 90 -3
- Partials 58 86 +28
Continue to review full report at Codecov.
|
In .travis.yml: # errors W605 and W504 added to avoid inconsistent errors happening
# error W605 happening on validators.py:28:40 on a valid Regex
# error W504 happening on validators.py:54:29 on a valid line break operator
- pycodestyle --ignore=W605,W504 --exclude='build' W605: The regex isn't quite valid, see #698 for a fix. Once that is merged, you should remove the W605 exception. As a general point, it might be better to avoid global exceptions as that means all the other code is excluded. Instead, you can skip checking single lines like this: regex = "\." # noqa Or better, skip checking only a single error type: regex = "\." # noqa: W605 Docs: https://pep8.readthedocs.io/en/latest/intro.html#error-codes |
Hello @moshemeirelles, |
Hello @moshemeirelles, Could you please merge this against our v4 branch? Thank you! With Best Regards, Elmer |
Thank you for suggestions @hugovk , I'll fix it 😄 For sure @thinkingserious |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to rebase against v4, not merge. This PR now includes all the other history from master, which we don't want. Please rebase to v4 and include only your new commits, and force push to your branch. Or, create a new PR to replace this one. Thanks!
Fixes #632
Checklist
Short description of what this PR does:
If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.