fixed changes suggested by grammarly #640

xeon-zolt · 2018-10-05T17:37:21Z

Fixes #639

Checklist

I have made a material change to the repo (functionality, testing, spelling, grammar)
I have read the [Contribution Guide] and my PR follows them.
I updated my branch with the master branch.
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation about the functionality in the appropriate .md file
I have added in line documentation to the code I modified

Short description of what this PR does:

made changes in files as suggested by Grammarly app

├── CHANGELOG.md
├── CODE_OF_CONDUCT.md
├── CONTRIBUTING.md
│   ├── README.md
│   └── USAGE.md
│   └── README.md
│   └── mail-helper-refactor.md
├── README.md
│   │   │   ├── README.md
│   │   │   ├── README.md
│   │       ├── README.md
├── TROUBLESHOOTING.md
├── USAGE.md
    ├── asynchronous_mail_send.md
    ├── attachment.md
    ├── aws.md
    ├── django.md
    ├── domain_whitelabel.md
    ├── email_stats.md
    ├── error_handling.md
    ├── flask_heroku.md
    ├── README.md
    ├── slack_event_api_integration.md
    └── transational_templates.md

SendGridDX · 2018-10-05T17:37:39Z

All committers have signed the CLA.

codecov · 2018-10-05T17:42:13Z

Codecov Report

Merging #640 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #640   +/-   ##
=======================================
  Coverage   85.03%   85.03%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          983      983           
  Misses         90       90           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cedb4cc...5599acf. Read the comment docs.

misterdorm

Thanks for picking this up! I've left several comments for nuances not picked up by Grammar.ly that should be reverted or changed to something else.

misterdorm · 2018-10-11T17:38:06Z

CODE_OF_CONDUCT.md

 ### Be Respectful
- Members of the community are respectful. We're respectful of others, their positions, their skills, their commitments and their efforts. We're respectful of the volunteer efforts that permeate the SendGrid community. We're respectful of the processes outlined in the community, and we work within them. When we disagree, we are courteous in raising our issues.  Overall, we're good to each other. We contribute to this community not because we have to, but because we want to. If we remember that, these guidelines will come naturally.
-
+ Members of the community are respectful. We're respectful of others, their positions, their skills, their commitments ,and their efforts. We're respectful of the volunteer efforts that permeate the SendGrid community. We're respectful of the processes outlined in the community, and we work within them. When we disagree, we are courteous in raising our issues.  Overall, we're good with each other. We contribute to this community not because we have to, but because we want to. If we remember that, these guidelines will come naturally.


Nit: Misplaced space around comma at "commitments ,and their efforts."

misterdorm · 2018-10-11T17:39:44Z

CONTRIBUTING.md

   contain your feature, change, or fix:

   ```bash
   git checkout -b <topic-branch-name>
   ```

-4. Commit your changes in logical chunks. Please adhere to these [git commit
+4. Commit your changes in logical chunks. Please adhere to these [git commits


'commit' in this context is a noun, not a verb. Trailing 's' not needed.

misterdorm · 2018-10-11T17:41:36Z

TROUBLESHOOTING.md

@@ -95,7 +95,7 @@ If you are using a [requirements file](https://pip.readthedocs.io/en/1.1/require
 <a name="versions"></a>
 ## Versioning Convention

-We follow the MAJOR.MINOR.PATCH versioning scheme as described by [SemVer.org](http://semver.org). Therefore, we recommend that you always pin (or vendor) the particular version you are working with to your code and never auto-update to the latest version. Especially when there is a MAJOR point release, since that is guaranteed to be a breaking change. Changes are documented in the [CHANGELOG](https://github.com/sendgrid/sendgrid-python/blob/master/CHANGELOG.md) and [releases](https://github.com/sendgrid/sendgrid-python/releases) section.
+We follow the MAJOR.MINOR.PATCH versioning scheme as described by [SemVer.org](http://semver.org). Therefore, we recommend that you always pin (or vendor) the particular version you are working with your code and never auto-update to the latest version. Especially when there is a MAJOR point release since that is guaranteed to be a breaking change. Changes are documented in the [CHANGELOG](https://github.com/sendgrid/sendgrid-python/blob/master/CHANGELOG.md) and [releases](https://github.com/sendgrid/sendgrid-python/releases) section.


Change to "...working with in your code...", feels more natural than the original "to your code". But only removing 'to' is not appropriate.

misterdorm · 2018-10-11T17:43:10Z

USAGE.md

@@ -70,7 +70,4628 @@ IP Access Management allows you to control which IP addresses can be used to acc

 For more information, please see our [User Guide](http://sendgrid.com/docs/User_Guide/Settings/ip_access_management.html).

-### POST /access_settings/whitelist


Was this change a mistake?

misterdorm · 2018-10-11T17:45:30Z

use_cases/aws.md

@@ -2,14 +2,14 @@

 This tutorial explains how to set up a simple "Hello Email" app on AWS, using the AWS CodeStar service.

-We'll be creating a basic web service to send email via SendGrid. The application will run on AWS Lambda, and the "endpoint" will be via AWS API Gateway.
+We'll be creating a basic web service to send an email via SendGrid. The application will run on AWS Lambda, and the "endpoint" will be via AWS API Gateway.


'email' is plural in this context, 'an' not needed.

misterdorm · 2018-10-11T17:46:50Z

use_cases/aws.md


-Once that's done, you've successfully created a CodeStar project! You should be at the dashboard, with a view of the wiki, change log, build pipeline, and application endpoint. 
+Once that's done, you've successfully created a CodeStar project! You should be at the dashboard, with a view of the wiki, changelog, build a pipeline, and application endpoint. 


'build' is a noun in this context, 'a' not needed.

misterdorm · 2018-10-11T17:49:25Z

use_cases/aws.md

'sending' is noun here, 'the' not needed.

misterdorm · 2018-10-11T17:49:43Z

use_cases/django.md

@@ -1,4 +1,4 @@
-# Create a Django app to send email with SendGrid
+# Create a Django app to send an email with SendGrid


'email' is plural, 'an' not needed.

misterdorm · 2018-10-11T17:50:20Z

use_cases/django.md

@@ -119,7 +119,7 @@ $ python manage.py migrate
 $ python manage.py runserver
 ```

-By default, it starts the development server at `http://127.0.0.1:8000/`. To test if we can send email or not, go to `http://127.0.0.1:8000/sendgrid/`. If it works, we should see the page says "Email Sent!".
+By default, it starts the development server at `http://127.0.0.1:8000/`. To test if we can send an email or not, go to `http://127.0.0.1:8000/sendgrid/`. If it works, we should see the page says "Email Sent!".


'email' is plural, 'an' not needed.

misterdorm · 2018-10-11T17:50:34Z

use_cases/flask_heroku.md

@@ -1,4 +1,4 @@
-# Create a Flask app to send email with SendGrid
+# Create a Flask app to send an email with SendGrid


'email' is plural, 'an' not needed.

misterdorm · 2018-10-15T19:40:40Z

Thanks @xeon-zolt ! Could you please address/explain the large amount of changes to USAGE.md?

xeon-zolt · 2018-10-18T06:29:14Z

@misterdorm please check again

misterdorm

Thanks!

thinkingserious · 2018-10-23T17:20:35Z

Hello @xeon-zolt,

Could you please resolve the merge conflicts? Thank you!

With Best Regards,

Elmer

thinkingserious · 2018-10-23T17:20:54Z

Hello @xeon-zolt,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious · 2018-10-25T23:36:10Z

Hello @xeon-zolt,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

thinkingserious · 2018-10-31T16:36:47Z

Hello @xeon-zolt,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

fixed changes suggested by grammerly

88ddc58

thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018

misterdorm added status: work in progress Twilio or the community is in the process of implementing hacktoberfest difficulty: medium fix is medium in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018

misterdorm requested changes Oct 11, 2018

View reviewed changes

fixed changes suggested

935a4d7

removed similar data and kept fixes

2793955

misterdorm approved these changes Oct 19, 2018

View reviewed changes

thinkingserious added the status: hacktoberfest approved label Oct 23, 2018

Merge branch 'master' into master

5599acf

thinkingserious merged commit 90cfbf2 into sendgrid:master Oct 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed changes suggested by grammarly #640

fixed changes suggested by grammarly #640

xeon-zolt commented Oct 5, 2018

SendGridDX commented Oct 5, 2018 •

edited

Loading

codecov bot commented Oct 5, 2018 •

edited

Loading

misterdorm left a comment

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm Oct 11, 2018

misterdorm commented Oct 15, 2018

xeon-zolt commented Oct 18, 2018

misterdorm left a comment

thinkingserious commented Oct 23, 2018

thinkingserious commented Oct 23, 2018

thinkingserious commented Oct 25, 2018

thinkingserious commented Oct 31, 2018

		@@ -70,7 +70,4628 @@ IP Access Management allows you to control which IP addresses can be used to acc

		For more information, please see our [User Guide](http://sendgrid.com/docs/User_Guide/Settings/ip_access_management.html).

		### POST /access_settings/whitelist


		Once that's done, you've successfully created a CodeStar project! You should be at the dashboard, with a view of the wiki, change log, build pipeline, and application endpoint.
		Once that's done, you've successfully created a CodeStar project! You should be at the dashboard, with a view of the wiki, changelog, build a pipeline, and application endpoint.

		@@ -1,4 +1,4 @@
		# Create a Django app to send email with SendGrid
		# Create a Django app to send an email with SendGrid

		@@ -1,4 +1,4 @@
		# Create a Flask app to send email with SendGrid
		# Create a Flask app to send an email with SendGrid

fixed changes suggested by grammarly #640

fixed changes suggested by grammarly #640

Conversation

xeon-zolt commented Oct 5, 2018

Fixes #639

Checklist

Short description of what this PR does:

SendGridDX commented Oct 5, 2018 • edited Loading

codecov bot commented Oct 5, 2018 • edited Loading

Codecov Report

misterdorm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

misterdorm commented Oct 15, 2018

xeon-zolt commented Oct 18, 2018

misterdorm left a comment

Choose a reason for hiding this comment

thinkingserious commented Oct 23, 2018

thinkingserious commented Oct 23, 2018

thinkingserious commented Oct 25, 2018

thinkingserious commented Oct 31, 2018

SendGridDX commented Oct 5, 2018 •

edited

Loading

codecov bot commented Oct 5, 2018 •

edited

Loading