Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed syntax errors in Kitchen sink Python example code #638

Merged
merged 3 commits into from
Oct 23, 2018

Conversation

vinayak42
Copy link
Contributor

@vinayak42 vinayak42 commented Oct 5, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixed syntax errors in Python code for Kitchen sink example in proposals/mail-helper-refactor.md

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #638 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1627df7...5fc6178. Read the comment docs.

@vinayak42
Copy link
Contributor Author

Can't understand why Travis CI build failed for Python 3.xx when I corrected importing of modules, but working fine on my system! Nonetheless, I have reverted my changes

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@vinayak42
Copy link
Contributor Author

@misterdorm Is this PR good to be merged?

@thinkingserious thinkingserious added type: bug bug in the library hacktoberfest difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @vinayak42,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit d1cc74a into sendgrid:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants