Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Add support for Python 3.7 #637

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 5, 2018

Like #615 but for the v4 branch.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@hugovk hugovk mentioned this pull request Oct 5, 2018
6 tasks
@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #637 into v4 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #637   +/-   ##
=======================================
  Coverage   84.38%   84.38%           
=======================================
  Files          37       37           
  Lines         967      967           
  Branches      108      108           
=======================================
  Hits          816      816           
  Misses         93       93           
  Partials       58       58

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6326325...91a234c. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 11, 2018
@thinkingserious
Copy link
Contributor

Hello @hugovk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 63b8134 into sendgrid:v4 Oct 11, 2018
@hugovk hugovk deleted the add-3.7-to-v4 branch October 11, 2018 21:34
@hugovk hugovk mentioned this pull request Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants