Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link for mail example #636

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Conversation

mattjegan
Copy link

@mattjegan mattjegan commented Oct 5, 2018

Fixes

Fixes #635

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • N/A I have added tests that prove my fix is effective or that my feature works
  • N/A I have added necessary documentation about the functionality in the appropriate .md file
  • N/A I have added in line documentation to the code I modified

Short description of what this PR does:

  • Fixes the broken 'examples' link in the mail helper readme.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 5, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 5, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #636 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #636   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3692e71...bf610ae. Read the comment docs.

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: easy fix is easy in difficulty and removed status: code review request requesting a community code review or review from Twilio labels Oct 11, 2018
@thinkingserious thinkingserious added hacktoberfest type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 11, 2018
@thinkingserious thinkingserious merged commit a319a30 into sendgrid:master Oct 11, 2018
@thinkingserious
Copy link
Contributor

Hello @mattjegan,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor broken link in mail helper docs
4 participants