Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Drop support for EOL Python 2.6 and 3.0-3.3 #626

Merged
merged 4 commits into from
Oct 4, 2018

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 3, 2018

This a version of #617 applied to the v4 branch.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

  • Drop support for EOL Python 2.6 and 3.0-3.3

Python 2.6 and 3.0-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.

Version Release date Supported until
2.6 2008-10-01 2013-10-29
3.0 2008-12-03 2009-06-27
3.1 2009-06-27 2012-04-09
3.2 2011-02-20 2016-02-27
3.3 2012-09-29 2017-09-29

They're also little used.

Here's the pip installs for sendgrid from PyPI for September 2018:

python_version percent download_count
2.7 43.21% 86,224
3.6 36.21% 72,262
3.4 9.08% 18,127
3.5 8.22% 16,410
3.7 3.03% 6,044
2.6 0.19% 374
3.3 0.06% 114
None 0.00% 1
Total 199,556

Source: pypinfo --start-date 2018-09-01 --end-date 2018-09-30 --percent --markdown sendgrid pyversion

I see #352 (comment) notes support for 2.6 is planned to be dropped in the next SDK version, and I don't think 3.0-3.2 were supported anyway.

This PR also upgrades code to use newer Python syntax, removes some old compatibility code, and fixes some flake8 and inspection warnings.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 3, 2018
@codecov
Copy link

codecov bot commented Oct 3, 2018

Codecov Report

Merging #626 into v4 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##               v4     #626   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files          37       37           
  Lines         952      952           
  Branches      105      105           
=======================================
  Hits          803      803           
  Misses         92       92           
  Partials       57       57
Impacted Files Coverage Δ
sendgrid/helpers/mail/to_email.py 100% <ø> (ø) ⬆️
sendgrid/helpers/inbound/send.py 93.75% <ø> (ø) ⬆️
sendgrid/helpers/mail/plain_text_content.py 41.17% <ø> (ø) ⬆️
sendgrid/helpers/mail/html_content.py 41.17% <ø> (ø) ⬆️
sendgrid/helpers/mail/content.py 84.61% <ø> (ø) ⬆️
sendgrid/helpers/mail/from_email.py 100% <ø> (ø) ⬆️
sendgrid/helpers/mail/validators.py 44.44% <ø> (ø) ⬆️
sendgrid/sendgrid.py 85.71% <100%> (ø) ⬆️
sendgrid/helpers/mail/mail.py 100% <100%> (ø) ⬆️
sendgrid/helpers/mail/exceptions.py 66.66% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56a0ad0...3b01e12. Read the comment docs.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 4, 2018
@thinkingserious
Copy link
Contributor

Hello @hugovk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit ae378dc into sendgrid:v4 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants