-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master: Drop support for EOL Python 2.6 and 3.0-3.3 #617
Conversation
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 35 35
Lines 1156 1156
Branches 172 172
=======================================
Hits 980 980
Misses 90 90
Partials 86 86
Continue to review full report at Codecov.
|
Hello @hugovk, Could you please move these changes to this branch? Thanks! With Best Regards, Elmer |
Please see PR #626. |
Checklist
Short description of what this PR does:
Python 2.6 and 3.0-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.
They're also little used.
Here's the pip installs for sendgrid from PyPI for September 2018:
Source:
pypinfo --start-date 2018-09-01 --end-date 2018-09-30 --percent --markdown sendgrid pyversion
I see #352 (comment) notes support for 2.6 is planned to be dropped in the next SDK version, and I don't think 3.0-3.2 were supported anyway.
This PR also upgrades code to use newer Python syntax, removes some old compatibility code, and fixes some flake8 and inspection warnings.