Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: Drop support for EOL Python 2.6 and 3.0-3.3 #617

Closed
wants to merge 7 commits into from

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 1, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • [n/a] I have added in line documentation to the code I modified

Short description of what this PR does:

  • Drop support for EOL Python 2.6 and 3.0-3.3

Python 2.6 and 3.0-3.3 are EOL and no longer receiving security updates (or any updates) from the core Python team.

Version Release date Supported until
2.6 2008-10-01 2013-10-29
3.0 2008-12-03 2009-06-27
3.1 2009-06-27 2012-04-09
3.2 2011-02-20 2016-02-27
3.3 2012-09-29 2017-09-29

They're also little used.

Here's the pip installs for sendgrid from PyPI for September 2018:

python_version percent download_count
2.7 43.21% 86,224
3.6 36.21% 72,262
3.4 9.08% 18,127
3.5 8.22% 16,410
3.7 3.03% 6,044
2.6 0.19% 374
3.3 0.06% 114
None 0.00% 1
Total 199,556

Source: pypinfo --start-date 2018-09-01 --end-date 2018-09-30 --percent --markdown sendgrid pyversion

I see #352 (comment) notes support for 2.6 is planned to be dropped in the next SDK version, and I don't think 3.0-3.2 were supported anyway.

This PR also upgrades code to use newer Python syntax, removes some old compatibility code, and fixes some flake8 and inspection warnings.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 1, 2018
@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #617 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #617   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files          35       35           
  Lines        1156     1156           
  Branches      172      172           
=======================================
  Hits          980      980           
  Misses         90       90           
  Partials       86       86
Impacted Files Coverage Δ
sendgrid/helpers/mail/validators.py 44.44% <ø> (ø) ⬆️
sendgrid/helpers/inbound/send.py 93.75% <ø> (ø) ⬆️
sendgrid/helpers/endpoints/ip/unassigned.py 15% <ø> (ø) ⬆️
sendgrid/helpers/mail/content.py 84.61% <ø> (ø) ⬆️
sendgrid/sendgrid.py 92% <100%> (ø) ⬆️
sendgrid/helpers/mail/exceptions.py 66.66% <100%> (ø) ⬆️
sendgrid/helpers/inbound/app.py 78.26% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc45b63...151bcac. Read the comment docs.

@hugovk hugovk changed the title Rm eol Drop support for EOL Python 2.6 and 3.0-3.3 Oct 1, 2018
@thinkingserious
Copy link
Contributor

Hello @hugovk,

Could you please move these changes to this branch? Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 2, 2018
@hugovk
Copy link
Contributor Author

hugovk commented Oct 3, 2018

Please see PR #626.

@hugovk hugovk changed the title Drop support for EOL Python 2.6 and 3.0-3.3 master: Drop support for EOL Python 2.6 and 3.0-3.3 Oct 3, 2018
@hugovk hugovk deleted the rm-eol branch October 4, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants