Issue #587 Change type of category in Mail.add_category from string to Category #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
|
How I can rebuild again without any commit? |
|
No need to worry about that, we'll take care of it in the code review. Thanks! |
thinkingserious
added
type: community enhancement
af4ro
reviewed
Aug 6, 2018
| @@ -376,9 +376,9 @@ def categories(self): | |||
| return self._categories | |||
|
|
|||
| def add_category(self, category): | |||
| """Add a Category to this Mail. Must be less than 255 characters. | |||
There was a problem hiding this comment.
What was your reason behind this deletion?
There was a problem hiding this comment.
Since Category is a Category type Must be less than 255 characters. is not suitable.
|
|
||
| :type category: string | ||
| :type category: Category |
There was a problem hiding this comment.
This is correct, thank you for pointing it out!
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
=======================================
Coverage 86.61% 86.61%
=======================================
Files 32 32
Lines 979 979
Branches 131 131
=======================================
Hits 848 848
Misses 67 67
Partials 64 64
Continue to review full report at Codecov.
|
af4ro
added
status: ready for deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#587
Checklist
Short description of what this PR does: