Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure params are applied independently #554

Merged

Conversation

ninoslavmilenovic
Copy link
Contributor

@ninoslavmilenovic ninoslavmilenovic commented Feb 18, 2018

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Allows for optional params for the Mail object to be applied even if not all of them are supplied.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Feb 18, 2018
@SendGridDX
Copy link

SendGridDX commented Feb 18, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thanks @rubyengineer! This in on our backlog for code review.

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 9ab6672 into sendgrid:master Jun 6, 2018
@thinkingserious
Copy link
Contributor

Hello @rubyengineer,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants