Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in test_env #543

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Conversation

mbonnefoy
Copy link
Contributor

This PR fixes the test_env test.
The project uses .env_sample (with a dot) and this seems to be the name of the file expected from both the comment above the test and the readme.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 11, 2017
@SendGridDX
Copy link

SendGridDX commented Dec 11, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

Thank you @mbonnefoy!

This has been added to our backlog for review.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 11, 2018
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 595f4e0 into sendgrid:master Jun 6, 2018
@thinkingserious
Copy link
Contributor

Hello @mbonnefoy,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@mbonnefoy mbonnefoy deleted the fix-test-env-typo branch June 10, 2018 09:38
@mbonnefoy
Copy link
Contributor Author

Hi @thinkingserious

That was really a minor contribution! Let's keep the swag for when I have something bigger to add. ;)

All the best,
Matthieu

@thinkingserious
Copy link
Contributor

Hi @mbonnefoy,

We prefer to give you swag now and enjoy your future contributions later :)

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants