Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix master failure on travis (relating to ASM raise-assertion). #524

Closed
wants to merge 1 commit into from
Closed

Fix master failure on travis (relating to ASM raise-assertion). #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sendgrid/helpers/mail/asm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def __init__(self, group_id=None, groups_to_display=None):
self._group_id = group_id
Copy link
Contributor

@delirious-lettuce delirious-lettuce Oct 31, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually came across the one you fixed, this one and one other one too: #484 (review)

# Shouldn't this...
self._group_id = group_id

# be this?
self.group_id = group_id

Maybe you could fix this one and add another commit for the one inside sendgrid/helpers/mail/category.Category as well?

# Shouldn't this...
self._name = name

# be this?
self.name = name

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goal here was to fix tests on the master branch -- we should probably address the wider question of dog-fooding setters inside init (I agree with you) after master gets green.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lettuce means that the master failure was caused by a typo, of which two others exist without unit tests to fail. It might be nice to fix them in this PR since they're the "same" problem.


if groups_to_display is not None:
self._groups_to_display = groups_to_display
self.groups_to_display = groups_to_display

@property
def group_id(self):
Expand Down