-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix master failure on travis (relating to ASM raise-assertion). #524
Conversation
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=========================================
Coverage ? 83.15%
=========================================
Files ? 30
Lines ? 1027
Branches ? 162
=========================================
Hits ? 854
Misses ? 83
Partials ? 90
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #524 +/- ##
=========================================
Coverage ? 83.15%
=========================================
Files ? 30
Lines ? 1027
Branches ? 162
=========================================
Hits ? 854
Misses ? 83
Partials ? 90
Continue to review full report at Codecov.
|
@@ -16,7 +16,7 @@ def __init__(self, group_id=None, groups_to_display=None): | |||
self._group_id = group_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually came across the one you fixed, this one and one other one too: #484 (review)
# Shouldn't this...
self._group_id = group_id
# be this?
self.group_id = group_id
Maybe you could fix this one and add another commit for the one inside sendgrid/helpers/mail/category.Category
as well?
# Shouldn't this...
self._name = name
# be this?
self.name = name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My goal here was to fix tests on the master branch -- we should probably address the wider question of dog-fooding setters inside init (I agree with you) after master gets green.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lettuce means that the master failure was caused by a typo, of which two others exist without unit tests to fail. It might be nice to fix them in this PR since they're the "same" problem.
I'm both pleased that adding the ASM validation stuff exposed an existing bug and aggravated that I didn't run tests locally and catch it myself. |
Checklist
Short description of what this PR does: