Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method_complexity issue in sendgrid/helpers/mail/ganalytics.py Fixes #498 #514

Merged
merged 2 commits into from
May 30, 2018

Conversation

chetankm-cs
Copy link
Contributor

@chetankm-cs chetankm-cs commented Oct 31, 2017

Fixes

Fixes #498

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Reduces the complexity of get and init method

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@chetankm-cs

We can’t merge your PR without the CLA being signed.

[ ] Sign the CLA before November 3rd
[ ] Tag @mbernier and @thinkingserious to let us know it is signed

Then we will comment with a link to get your shirt!

@chetankm-cs
Copy link
Contributor Author

@mbernier @thinkingserious
I have already signed CLA but when I do a recheck the cla check still fails.
Please help ?

@thinkingserious
Copy link
Contributor

Hi @chetankm-cs,

It looks like your commit was made by another user account "Chetan". Maybe the easiest thing to do is to re-create the PR under your @chetankm-cs account, reference this issue and close it.

With Best Regards,

Elmer

@chetankm-cs
Copy link
Contributor Author

@thinkingserious I have changed the author, the CLA check has passed. Thanks.

@thinkingserious
Copy link
Contributor

Thank you @chetankm-cs!

Please click here to fill out the form. Thanks!

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Feb 27, 2018
@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #514 into master will increase coverage by 0.45%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
+ Coverage   87.91%   88.36%   +0.45%     
==========================================
  Files          30       30              
  Lines         935      937       +2     
  Branches      115      112       -3     
==========================================
+ Hits          822      828       +6     
  Misses         55       55              
+ Partials       58       54       -4
Impacted Files Coverage Δ
sendgrid/helpers/mail/ganalytics.py 95.91% <90%> (+8.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a47420...5c895ea. Read the comment docs.

@thinkingserious thinkingserious merged commit 10ed936 into sendgrid:master May 30, 2018
@thinkingserious
Copy link
Contributor

Hello @chetankm-cs,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@chetankm-cs chetankm-cs deleted the refactor branch May 31, 2018 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix "method_complexity" issue in sendgrid/helpers/mail/ganalytics.py
4 participants