Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CONTRIBUTING.md #513

Merged
merged 1 commit into from
Jun 6, 2018
Merged

update CONTRIBUTING.md #513

merged 1 commit into from
Jun 6, 2018

Conversation

thepriefy
Copy link
Contributor

@thepriefy thepriefy commented Oct 31, 2017 •
edited
Loading

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • makes Environmental Variables a sub topic

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thepriefy
update CONTRIBUTING.md
3c78565 
makes Environmental Variables a sub topic
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 31, 2017
@rizzza
Copy link

rizzza commented Feb 13, 2018

LGTM

@rizzza rizzza self-requested a review February 13, 2018 21:51
@thinkingserious thinkingserious added type: bug bug in the library difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 490ed75 into sendgrid:master Jun 6, 2018
@thinkingserious
Copy link
Contributor

Hello @thepriefy,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rizzza rizzza Awaiting requested review from rizzza

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio type: bug bug in the library type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thepriefy @rizzza @thinkingserious @apigirl