Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix similar code issue in mail.js helper as per #458 #488

Closed
wants to merge 2 commits into from

Conversation

adiman9
Copy link

@adiman9 adiman9 commented Oct 29, 2017

I removed the duplicate code and refactored into a more general loop to reuse the code.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 29, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 29, 2017

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Oct 29, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@79d5ea7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage          ?   82.87%           
=========================================
  Files             ?       30           
  Lines             ?     1016           
  Branches          ?      157           
=========================================
  Hits              ?      842           
  Misses            ?       84           
  Partials          ?       90
Impacted Files Coverage Δ
sendgrid/helpers/mail/mail.py 97.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d5ea7...7178206. Read the comment docs.

@thinkingserious
Copy link
Contributor

@adiman9

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@thinkingserious thinkingserious added the type: community enhancement feature request not on Twilio's roadmap label Feb 27, 2018
@adiman9 adiman9 closed this May 18, 2018
@thinkingserious
Copy link
Contributor

Hi @adiman9,

I'm looking to merge this within the coming weeks. Now that we've launched our PHP SDK v7 I'm turning my focus to this SDK. Could you please take a moment to resolve the merge conflicts.

Thanks!

With Best Regards,

Elmer

@thinkingserious
Copy link
Contributor

Thanks again for helping improve this SDK!

We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants