-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix similar code issue in mail.js helper as per #458 #488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
=========================================
Coverage ? 82.87%
=========================================
Files ? 30
Lines ? 1016
Branches ? 157
=========================================
Hits ? 842
Misses ? 84
Partials ? 90
Continue to review full report at Codecov.
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
Hi @adiman9, I'm looking to merge this within the coming weeks. Now that we've launched our PHP SDK v7 I'm turning my focus to this SDK. Could you please take a moment to resolve the merge conflicts. Thanks! With Best Regards, Elmer |
Thanks again for helping improve this SDK! We have started to execute on PR #347 (Python Mail Helper Refactor) and have integrated your work into this branch. Please follow along at PR #347 to follow our progress. With Best Regards, Elmer |
I removed the duplicate code and refactored into a more general loop to reuse the code.