Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Project tests #479

Merged
merged 3 commits into from
Nov 1, 2017
Merged

Add Project tests #479

merged 3 commits into from
Nov 1, 2017

Conversation

pjhampton
Copy link
Contributor

Fixes #475

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds project based unit tests to the repo. These check specific files exist.
  • There was the following errors:
(sendgrid-python) ∅ killa/sendgrid-python ‹pjhampton/add-tests*?› » python test/test_project.py                      146 ↵
....F.F.........
======================================================================
FAIL: test_docker_compose (__main__.ProjectTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_project.py", line 16, in test_docker_compose
    self.assertEqual(True, os.path.isfile('docker-compose.yml'))
AssertionError: True != False

======================================================================
FAIL: test_env (__main__.ProjectTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_project.py", line 20, in test_env
    self.assertEqual(True, os.path.isfile('./env_sample'))
AssertionError: True != False

----------------------------------------------------------------------
Ran 16 tests in 0.003s

FAILED (failures=2)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017

CLA assistant check
All committers have signed the CLA.

Copy link

@garuna-m6 garuna-m6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 27 , test for checking .travis.yml is wrong

@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 29, 2017
@pjhampton
Copy link
Contributor Author

@garuna-m6 Thanks! Updated.

@mbernier mbernier merged commit 0a57323 into sendgrid:master Nov 1, 2017
@thinkingserious
Copy link
Contributor

Hello @pjhampton,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@pjhampton pjhampton deleted the pjhampton/add-tests branch November 1, 2017 11:39
@mbernier
Copy link
Contributor

@pjhampton

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unittest to check for specific repo files
6 participants