-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Send.py #476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=========================================
Coverage ? 85.58%
=========================================
Files ? 30
Lines ? 1027
Branches ? 161
=========================================
Hits ? 879
Misses ? 57
Partials ? 91
Continue to review full report at Codecov.
|
I tried to merge master into my branch and resolve conflicts but something went wrong. @mbernier @thinkingserious could you please review my PR? |
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
Oh wow, that is super weird. I am going to see if I can get travis to kick over a build for us. WTF Travis!? |
I just merged sendgrid-python master, this caused Travis to show up. If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
Those tests failed. sendgrid-python/test/test_project.py Lines 10 to 20 in a403813
Looks like docker-compose.yml , env_sample are absent in master and ./docker/Dockerfile not a directory.
I think it would be better to comment failed tests if you want to use them later. |
Those file tests failing is expected behavior, because we have PRs coming that will resolve them. Thanks so much for following up! Please do grab a time on my calendar (see previous comment) Thanks!! |
Hello @artiemq, |
Fixes #417
Checklist
Changes proposed in this pull request:
Send
insend.py
Send.test_payload