Update config.py

[ajiteshr7]

Better file handling

[SendGridDX]

All committers have signed the CLA.

[codecov-io]

Codecov Report

Merging #423 into master will decrease coverage by 0.16%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
- Coverage   81.54%   81.38%   -0.17%     
==========================================
  Files           9        9              
  Lines         981      983       +2     
  Branches      156      156              
==========================================
  Hits          800      800              
- Misses         90       92       +2     
  Partials       91       91

Impacted Files	Coverage Δ
sendgrid/helpers/inbound/config.py	75.75% <0%> (-4.89%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0884519...428a9ae. Read the comment docs.

[mbernier]

Can you please help a newer Python dev understand why this is better? It seems the previous way is a bit cleaner?

[ajiteshr7]

As when opening a file in 'for loop' we aren't keeping any explicit reference to the opened file. Hence to close the file we need to get dependent on the garbage collector, but that may mean that the resources aren't freed in a timely manner. Also if an exception occurs file will not get closed when using for ... open.
Python provides with to handle these cases and using with makes the code more readable.
More on this here.

[mbernier]

Awesome, thank you for explaining this change @ajiteshr7!!

[thinkingserious]

Hello @ajiteshr7,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX