Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds how to set up domain whitelabel and how to view email statistics #384

Merged
merged 7 commits into from
Oct 24, 2017
Merged

Adds how to set up domain whitelabel and how to view email statistics #384

merged 7 commits into from
Oct 24, 2017

Conversation

adityatandon007
Copy link
Contributor

Adds documentation mentioned in issue #383

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 14, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 14, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@adityatandon007
Copy link
Contributor Author

@thinkingserious I couldn't understand the reason why travis is failing. I followed the contributing.md but couldn't understand why it is happening. Any help would be appreciated

@adityatandon007
Copy link
Contributor Author

@thinkingserious I think the travis job is broken for python 2.6. Thats why travis is complaining though not sure! Let me know if you can merge this.

thinkingserious
thinkingserious requested changes Oct 14, 2017
View reviewed changes
USE_CASES.md Outdated
@@ -169,3 +169,17 @@ print(response.status_code)
print(response.body)
print(response.headers)
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the Table of Contents entries and change sendgrid-csharp in the URLs to sendgrid-python.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@thinkingserious
Copy link
Contributor

Hi @adityatandon007,

Don't worry about the tests, our PR will be merged once you fix the issues in my review. Thanks!

With Best Regards,

Elmer

@adityatandon007
Copy link
Contributor Author

@thinkingserious changes done as requested. Let me know if you need any other changes

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 16, 2017
@adityatandon007
Copy link
Contributor Author

@thinkingserious waiting for your response on this

@adityatandon007
Copy link
Contributor Author

@thinkingserious still waiting

@codecov-io
Copy link

codecov-io commented Oct 24, 2017 •
edited
Loading

Codecov Report

Merging #384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   81.98%   81.98%           
=======================================
  Files           9        9           
  Lines         999      999           
  Branches      160      160           
=======================================
  Hits          819      819           
  Misses         90       90           
  Partials       90       90

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4302bff...b180613. Read the comment docs.

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 24, 2017
@thinkingserious thinkingserious merged commit 6114af5 into sendgrid:master Oct 24, 2017
@thinkingserious
Copy link
Contributor

Hello @adityatandon007,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@adityatandon007 adityatandon007 deleted the aditya/docs branch October 24, 2017 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adityatandon007 @SendGridDX @thinkingserious @codecov-io