-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code coverage check and codecov.io badge #352
Conversation
@@ -1,4 +1,5 @@ | |||
[![Travis Badge](https://travis-ci.org/sendgrid/sendgrid-python.svg?branch=master)](https://travis-ci.org/sendgrid/sendgrid-python) | |||
[![codecov](https://codecov.io/gh/meahow/sendgrid-python/branch/issue_251_coverage/graph/badge.svg)](https://codecov.io/gh/meahow/sendgrid-python) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This url need to be changed once you setup a (free) codecov.io account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thinkingserious can you please create this with the SendGridDX account?
The travis job is broken for py2.6 |
Codecov Report
@@ Coverage Diff @@
## master #352 +/- ##
=========================================
Coverage ? 81.24%
=========================================
Files ? 9
Lines ? 981
Branches ? 156
=========================================
Hits ? 797
Misses ? 90
Partials ? 94 Continue to review full report at Codecov.
|
Hi @meahow, We are dropping support for Python 2.6 in the next version of this SDK. I will still be able to merge your work. Thanks! With Best Regards, Elmer |
I attempted to merge the conflicts that popped up, hopefully it builds properly now! |
Hello @meahow, |
Thanks @thinkingserious, I just did. |
This should close #251
You might want to create separate codecov.io account for sendgrid-python project.
After this, the badge url should be changed in README.md