Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage check and codecov.io badge #352

Merged
merged 6 commits into from
Oct 22, 2017

Conversation

meahow
Copy link
Contributor

@meahow meahow commented Oct 2, 2017

This should close #251
You might want to create separate codecov.io account for sendgrid-python project.
After this, the badge url should be changed in README.md

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 2, 2017

CLA assistant check
All committers have signed the CLA.

@@ -1,4 +1,5 @@
[![Travis Badge](https://travis-ci.org/sendgrid/sendgrid-python.svg?branch=master)](https://travis-ci.org/sendgrid/sendgrid-python)
[![codecov](https://codecov.io/gh/meahow/sendgrid-python/branch/issue_251_coverage/graph/badge.svg)](https://codecov.io/gh/meahow/sendgrid-python)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This url need to be changed once you setup a (free) codecov.io account

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkingserious can you please create this with the SendGridDX account?

@meahow
Copy link
Contributor Author

meahow commented Oct 2, 2017

The travis job is broken for py2.6

@codecov-io
Copy link

codecov-io commented Oct 2, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@5abeaa6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #352   +/-   ##
=========================================
  Coverage          ?   81.24%           
=========================================
  Files             ?        9           
  Lines             ?      981           
  Branches          ?      156           
=========================================
  Hits              ?      797           
  Misses            ?       90           
  Partials          ?       94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5abeaa6...9a97cf8. Read the comment docs.

@thinkingserious
Copy link
Contributor

Hi @meahow,

We are dropping support for Python 2.6 in the next version of this SDK.

I will still be able to merge your work.

Thanks!

With Best Regards,

Elmer

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 2, 2017
@mbernier
Copy link
Contributor

I attempted to merge the conflicts that popped up, hopefully it builds properly now!

@mbernier mbernier merged commit eb8823b into sendgrid:master Oct 22, 2017
@thinkingserious
Copy link
Contributor

Hello @meahow,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@meahow
Copy link
Contributor Author

meahow commented Oct 22, 2017

Thanks @thinkingserious, I just did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage
5 participants