Permit unicode string values with Substitution helper #335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #334
The issue was with using unicode values in substitutions. In this PR, I removed forced casting to ascii for values used with Substitutions. It seems that other helpers don't cast values to ascii.
Example code that would cause an error:
personalization.add_substitution(Substitution("%city%", u"Αθήνα"))
I created a simple test to see that the Substitutions helper can now handle a unicode string. All tests pass.
I also tested this in an end-to-end workflow, where we submitted data into our form and received a live email with unicode values where expected.
This is my first public pull request on Github, please let me know if I am missing anything required here.