Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #250

Merged
merged 5 commits into from
Mar 29, 2017
Merged

Conversation

andriisoldatenko
Copy link
Contributor

Summary

According to CONTRIBUTING code should pass all pep8 and flake8 errors

On master branch we can see

(python-sedgrid) ~/sendgrid-python$ flake8 . | wc -l
1201
OR
pep8 . | wc -l
1033

The goal of this PR to fix all errors.

After this PR merged:

flake8 test/ | wc -l 
test/test_mail.py:212:80: E501 line too long (3359 > 79 characters)

Checks on sendgrid/ module:

flake8 sendgrid/ wc -l

Unit tests:

----------------------------------------------------------------------
Ran 238 tests in 32.903s

OK

Install checking tools:

pip install flake8 pep8 isort

@andriisoldatenko
Copy link
Contributor Author

@thinkingserious Please review.
cc @vananabu

@thinkingserious
Copy link
Contributor

Awesome @andriisoldatenko!

Could you please sign our CLA so I can review and merge? Thanks!

@thinkingserious thinkingserious added status: cla needed status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Nov 10, 2016
@andriisoldatenko
Copy link
Contributor Author

@thinkingserious done.

@thinkingserious
Copy link
Contributor

Hi @andriisoldatenko,

Could you please fix the conflicts in test/test_sendgrid.py? Thanks!

@andriisoldatenko
Copy link
Contributor Author

@thinkingserious done.

@andriisoldatenko
Copy link
Contributor Author

@thinkingserious Can you please review again. Thanks

@SendGridDX SendGridDX merged commit beed6e4 into sendgrid:master Mar 29, 2017
@SendGridDX
Copy link

Hi @andriisoldatenko,

Thanks again for the PR, please take a moment to fill out this form so that we may send you some swag :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants