New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove async example #1094

Open

e-carlin wants to merge 1 commit into sendgrid:main from e-carlin:988-remove-async-example

Commits on Oct 30, 2024

Fix sendgrid#988 : Remove async example

The async example never actually worked in an async way. It tricked
users into thinking they were using async code but in reality the
sendgrid_client.send call (which is what was waiting on I/O) was still
blocking.

In addition, asyncio.async (used in the example) was deprecated in
Python 3.7 and removed in Python 3.10.

e-carlin committed Oct 30, 2024