Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add reply_to_list functionality #1062

Merged
merged 5 commits into from
Mar 21, 2023

Conversation

thepuzzlemaster
Copy link
Contributor

reply_to_list exists in the sendgrid API v3, but it has never been implemented for the python api.

I added tests and a use case, but I didn't see any other docs. But this property already exists in the official docs.

Also, I never code in python, so I may have made some mistakes here. Just kind of based this off of the existing code and some googling.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • [-] I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@thepuzzlemaster
Copy link
Contributor Author

Does anyone at Sendgrid maintain this repo?
@childish-sambino or @eshanholtz? I see you both have approved/merged the most recent PR's.
I don't see any information in the .md files about requesting reviewers, so not sure if I missed a step perhaps.

sendgrid/helpers/mail/mail.py Outdated Show resolved Hide resolved
sendgrid/helpers/mail/mail.py Outdated Show resolved Hide resolved
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino merged commit 4b5c605 into sendgrid:main Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants