Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Python 3.11 to the testing #1059

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 9, 2022

Fixes

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

@sk-
Copy link

sk- commented Mar 11, 2023

@cclauss do you have plans to continue this PR?

It would also be good to add Python 3.11 to the list of classifiers.

The CI is failing because the name of the PR is not following conventional commits (this is the action checking that).

@cclauss cclauss changed the title Add Python 3.11 to the testing feat: Add Python 3.11 to the testing Mar 11, 2023
@cclauss
Copy link
Contributor Author

cclauss commented Mar 11, 2023

I was worried to touch the classifiers because python_requires says no Py34 and the classifiers say yes Py34 when in fact no one uses Py34 anymore. https://devguide.python.org/versions

OK. This linter seems happy...

@sk-
Copy link

sk- commented Mar 11, 2023

But we are still waiting for an approval from maintainers to be able to run the tests. @childish-sambino could you grant permissions.

Screen Shot 2023-03-11 at 15 01 14

@childish-sambino childish-sambino merged commit 9e8a259 into sendgrid:main Mar 13, 2023
@cclauss cclauss deleted the patch-1 branch March 13, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants