Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge test and deploy workflows #1039

Conversation

Hunga1
Copy link
Contributor

@Hunga1 Hunga1 commented Jan 31, 2022

Merges the test and deploy GitHub Action workflows into a single test and deploy workflow.

Changes:

  • Renamed 'tests' job to 'test'
  • Renamed 'release' job to 'deploy'
  • Deploy job now relies on the test job to pass
  • Deploy job only runs on tags

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Added test and deploy GH action workflow that combines the original tests and release workflows. Release job now relies on the tests job, and only runs on tags. Slack failure notification now handles both test and release failures for either the main branch or tags.
.github/workflows/test-and-deploy.yml Outdated Show resolved Hide resolved
.github/workflows/test-and-deploy.yml Outdated Show resolved Hide resolved
Removed python setup job step that's no longer used. Fixed docker build and test job step.
Checkout job step now fetches the latest commit. Updated build status badge.
@childish-sambino childish-sambino merged commit bbd1319 into sendgrid:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants