Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: split up unit and integ tests #1029

Merged
merged 1 commit into from
Dec 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ test-install: install
. venv/bin/activate; pip install -r test/requirements.txt

test: test-install
. venv/bin/activate; coverage run -m unittest discover -s test/unit

test-integ: test
. venv/bin/activate; coverage run -m unittest discover
. venv/bin/activate; coverage run -m unittest discover -s test/integ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does test-integ also run the unit tests? Shouldn't it only depend on test-install?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it would be nice to run both since the unit tests are pretty quick, plus the docker-test workflow calls make test-integ so it will run the unit tests too.


version ?= latest
test-docker:
Expand Down
Empty file added test/integ/__init__.py
Empty file.
File renamed without changes.
Empty file added test/unit/__init__.py
Empty file.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.