Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin starkbank-ecdsa version #1015

Merged
merged 1 commit into from
Oct 11, 2021
Merged

chore: pin starkbank-ecdsa version #1015

merged 1 commit into from
Oct 11, 2021

Conversation

eshanholtz
Copy link
Contributor

Fixes #1014

@eshanholtz eshanholtz merged commit 77ae5f5 into main Oct 11, 2021
@eshanholtz eshanholtz deleted the dep-fix branch October 11, 2021 18:31
@shwetha-manvinkurke
Copy link
Contributor

shwetha-manvinkurke commented Oct 11, 2021

Doesn't work for versions <3.6 looks like - https://app.travis-ci.com/github/sendgrid/sendgrid-python

@amcquistan
Copy link

need to fix this in setup.py otherwise I don't think this will pip install correctly from PyPI

def getRequires():
    deps = [
        'python_http_client>=3.2.1',
        'starkbank-ecdsa>=1.0.0,<2.0.0'
    ]
    return deps

@amcquistan
Copy link

the following will use the dependencies in setup.py which is why the CircleCI builds are failing. The dependencies in setup.py need to be pinned to starkbank-ecdsa>=1.0.0,<2.0.0

Step 8/8 : RUN make install
 ---> Running in cb501b823e17
find . -name \*.pyc -delete
rm -rf venv
Python 2.7.18
virtualenv --python=python venv
created virtual environment CPython2.7.18.final.0-64 in 265ms
  creator CPython2Posix(dest=/app/venv, clear=False, global=False)
  seeder FromAppData(download=False, pip=latest, setuptools=latest, wheel=latest, via=copy, app_data_dir=/root/.local/share/virtualenv/seed-app-data/v1.0.1)
  activators PythonActivator,CShellActivator,FishActivator,PowerShellActivator,BashActivator
. venv/bin/activate; python setup.py install

You can see in the output of the build it is still trying to use version 2.0.0

  File "/app/venv/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1731, in zipinfo
    return self._zip_manifests.load(self.loader.archive)
  File "/app/venv/lib/python2.7/site-packages/pip/_vendor/pkg_resources/__init__.py", line 1688, in load
    mtime = os.stat(path).st_mtime
OSError: [Errno 2] No such file or directory: '/app/venv/lib/python2.7/site-packages/starkbank_ecdsa-2.0.0-py2.7.egg'
make: *** [Makefile:9: install] Error 1

@eshanholtz
Copy link
Contributor Author

Ah, great catch! thanks @amcquistan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signed webhook verification fails
3 participants