Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "similar-code" issue in sendgrid/helpers/mail/mail.py #503

Closed
thinkingserious opened this issue Oct 30, 2017 · 2 comments
Closed

Fix "similar-code" issue in sendgrid/helpers/mail/mail.py #503

thinkingserious opened this issue Oct 30, 2017 · 2 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Similar blocks of code found in 6 locations. Consider refactoring.

https://codeclimate.com/github/sendgrid/sendgrid-python/sendgrid/helpers/mail/mail.py#issue_59f639d0343eae000100008c
palash16 added a commit to palash16/sendgrid-python that referenced this issue Oct 30, 2017
@palash16
refactors code, issue sendgrid#503
4fb3734
@palash16 palash16 mentioned this issue Oct 30, 2017
Closed
@nanspro nanspro mentioned this issue Oct 30, 2017
Closed
6 tasks
palash16 added a commit to palash16/sendgrid-python that referenced this issue Oct 30, 2017
@palash16
refactors code, issue sendgrid#503
19e1a70 
refactors code
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: work in progress Twilio or the community is in the process of implementing difficulty: medium fix is medium in difficulty labels Feb 27, 2018
@lifez
Copy link
Contributor

lifez commented Aug 17, 2018

@thinkingserious Does this issue need to be done?

@thinkingserious
Copy link
Contributor Author

Hi @lifez,

Sorry, I should have closed this. I will be incorporating this change in the next version of this SDK.

Thanks for checking!

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
2 participants
@thinkingserious @lifez