Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unittest to check the license.md file date range #474

Closed
thinkingserious opened this issue Oct 28, 2017 · 1 comment · Fixed by #480
Closed

Add a unittest to check the license.md file date range #474

thinkingserious opened this issue Oct 28, 2017 · 1 comment · Fixed by #480
Labels
difficulty: unknown or n/a fix is unknown in difficulty

Comments

@thinkingserious
Copy link
Contributor

The end year in the license file should be "this year" and this should be checked on every run of the tests. If the end year is no correct, fail the test.
example:

Copyright (c) 2012-2016 SendGrid, Inc.
It is 2017, so this should be:
Copyright (c) 2012-2017 SendGrid, Inc.
and the test should fail.
--done

@nishithshah2211
Copy link

Hey, I'd like to work on this. I am already working on the same issue in the smtpapi-python repo. Should I go ahead with using regex to parse for the year or does anyone want to suggest a better way to do it?

Also, the license file is license.txt and not license.md right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: unknown or n/a fix is unknown in difficulty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants