Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pep8 Compliance #464

Closed
mbernier opened this issue Oct 27, 2017 · 4 comments
Closed

Pep8 Compliance #464

mbernier opened this issue Oct 27, 2017 · 4 comments
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@mbernier
Copy link
Contributor

Issue Summary

According to this report, there are a lot of Pep8 issues. Can you fix them?

https://codeclimate.com/github/sendgrid/sendgrid-python/pull/463

Acceptance criteria:

Code climate should pass when you make your PR.
@mbernier mbernier added difficulty: easy fix is easy in difficulty good first issue labels Oct 27, 2017
@blackpioter
Copy link
Contributor

I'll take it @mbernier

@blackpioter
Copy link
Contributor

BTW. Please consider ignoring PEP8 E501 (line too long). There are parts of code with i.e links that will be hard to shorten.

@blackpioter blackpioter mentioned this issue Oct 27, 2017
Merged
@gardlt gardlt mentioned this issue Oct 29, 2017
Closed
6 tasks
@mbernier
Copy link
Contributor Author

mbernier commented Nov 1, 2017

That makes sense to me.

@SidduH SidduH mentioned this issue Nov 1, 2017
Merged
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed good first issue labels Feb 27, 2018
@childish-sambino
Copy link
Contributor

Fixed by #466

@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

making code pep8 compllient gardlt/sendgrid-python
4 participants
@thinkingserious @mbernier @blackpioter @childish-sambino