Asyncio example is completely wrong, update #988
Comments
thinkingserious
changed the title
|
Hello @agronick, Thank you for raising this issue! This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog. Here are some related issues and PRs to consider upon update:
With best regards, Elmer |
thinkingserious
added
status: help wanted
|
#953 is exactly what I'm talking about but it was closed. |
|
upvote. unfortunately current SDK is not compatible with asyncio which makes it unusable with such things like aiohttp or fastapi |
|
Hi, it's 2024 and the example is still wrong. Open to PRs? I can help It's as simple as wrapping the call using asyncio.to_thread so it doesn't block the main thread. Ideally though the SDK itself would provide support for asyncio, maybe through a transport layer that uses aiohttp or httpx |
|
I'll just use the api lol |
The async example never actually worked in an async way. It tricked users into thinking they were using async code but in reality the sendgrid_client.send call (which is what was waiting on I/O) was still blocking. In addition, asyncio.async (used in the example) was deprecated in Python 3.7 and removed in Python 3.10.
Issue Summary
I'm talking about this example https://github.com/sendgrid/sendgrid-python/blob/main/use_cases/asynchronous_mail_send.md
Steps to Reproduce
Using asyncio is more than just putting
asyncin front of the function doing the http request. In fact this is the completely wrong way to useasyncioand will actually destroys performance as this blocks the event loop from doing any other work while the http request is being made.To use asyncio correctly the tcp socket sending the data must be using asyncio and one of the low level asyncio socket functions. https://docs.python.org/3/library/asyncio-stream.html These are awaited, allowing the event loop to do other work.
What you have suggested is EXTREMELY bad practice and will stall the servers of anyone who uses it. This is why you can't use
requestsorurllibwith asyncio. You have to use something like aiohttp.The right way to use asyncio with your library is to run it in a thread pool executor so that the blocking IO stays off the main thread.
You would be better off deleting that example than keeping it in it's current form.
The text was updated successfully, but these errors were encountered: