Helpers: Personalization - From

[lopenchi]

Issue Summary

Checking the request body for mail/send (https://docs.sendgrid.com/api-reference/mail-send/mail-send), it was discovered that helper classes provided in this library can be improved

Errors found:

• In Presonalization class there is a property $from, which is an object. Based in all the code the object setter method is setObjectName, but in this case is addFrom as the from property is an array, but it is an object

Code:

sendgrid-php/lib/mail/Personalization.php

Line 69 in 3dcfc4d

public function addFrom($email)

This is also confusing because in Mail class the method is setFrom

[JenniferMah]

Hi @lopenchi! Thanks for bringing this to our attention. This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog.

[lopenchi]

@JenniferMah Can you send me the link for the ticket ? I would like to +1

[childish-sambino]

@lopenchi Putting a 👍 on the issue summary is what's needed.