Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Travis-CI python 3.6 support #89

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Add missing Travis-CI python 3.6 support #89

merged 1 commit into from
Aug 14, 2018

Conversation

duboviy
Copy link
Contributor

@duboviy duboviy commented Aug 14, 2018

Build (all python interpreter versions) passed, following link provided below:
https://travis-ci.org/duboviy/python-http-client

[Additional Note]:
Python 3.7 can't be added right now due to Travis-CI issue:
travis-ci/travis-ci#9815
Python 3.7 could be added now only with dirty workaround: dist: xenial & sudo: true need to be specified (I'd suggest to wait travis-ci/travis-ci#9815 fixed and add 3.7 normally in separate PR).

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Aug 14, 2018
@SendGridDX
Copy link

SendGridDX commented Aug 14, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files           6        6           
  Lines         298      298           
=======================================
  Hits          273      273           
  Misses         25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2c217...de7d02b. Read the comment docs.

@thinkingserious thinkingserious merged commit b7b9fc3 into sendgrid:master Aug 14, 2018
@thinkingserious
Copy link
Contributor

Hello @duboviy,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@duboviy
Copy link
Contributor Author

duboviy commented Aug 14, 2018

Hello,

Done. Thanks a lot!

Have a nice day, @thinkingserious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants