Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove ResourceWarning on module import #128

Merged
merged 2 commits into from
Mar 19, 2020
Merged

fix: Remove ResourceWarning on module import #128

merged 2 commits into from
Mar 19, 2020

Conversation

connesy
Copy link
Contributor

@connesy connesy commented Oct 17, 2019

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Removes ResourceWarning on module import and from setup.py:

$ python -Wd
>>> import python_http_client
/home/<user>/miniconda3/envs/dev/lib/python3.7/site-packages/python_http_client/__init__.py:22: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/<user>/miniconda3/envs/dev/lib/python3.7/site-packages/python_http_client/VERSION.txt' mode='r' encoding='UTF-8'>
  __version__ = open(os.path.join(dir_path, 'VERSION.txt')).read().strip()
ResourceWarning: Enable tracemalloc to get the object allocation traceback

If you have questions, please send an email to the Twilio SendGrid Developer Experience Team, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 17, 2019
@SendGridDX
Copy link

SendGridDX commented Oct 17, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino changed the title Remove ResourceWarning on module import fix: Remove ResourceWarning on module import Mar 19, 2020
@childish-sambino childish-sambino merged commit 9a63d4b into sendgrid:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants