feat: add API logging to client #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkingserious
added
the
status: code review request
|
|
|
Will this PR be merged? |
|
Hello @tysonholub, I'm not sure just yet, it's still in our backlog for a code review. My apologies for the delay and thank you for your patience. With Best Regards, Elmer |
thinkingserious
added
difficulty: medium
childish-sambino
removed
the
type: community enhancement
Codecov Report
@@ Coverage Diff @@
## main #123 +/- ##
==========================================
- Coverage 92.73% 92.45% -0.29%
==========================================
Files 6 6
Lines 303 305 +2
==========================================
+ Hits 281 282 +1
- Misses 22 23 +1
Continue to review full report at Codecov.
|
childish-sambino
suggested changes
Aug 6, 2020
|
Fixes #141 |
childish-sambino
changed the title
added 2 commits
August 6, 2020 14:10
elgonost
added a commit
to elgonost/python-http-client
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logging to the client API calls and additionally the API request method to the client Response