Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String Formatting and PEP-8 fixes #111

Merged
merged 2 commits into from
Oct 30, 2018

Conversation

vkmrishad
Copy link
Contributor

@vkmrishad vkmrishad commented Oct 20, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

Short description of what this PR does:

  • PEP8 fixes
  • String formatting enhancement

If you have questions, please send an email to SendGrid, or file a GitHub Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 20, 2018
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #111 into master will decrease coverage by 24.22%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #111       +/-   ##
===========================================
- Coverage   91.34%   67.12%   -24.23%     
===========================================
  Files           6        6               
  Lines         289      289               
===========================================
- Hits          264      194       -70     
- Misses         25       95       +70
Impacted Files Coverage Δ
tests/test_unit.py 69.59% <ø> (-29.61%) ⬇️
tests/test_repofiles.py 100% <ø> (ø) ⬆️
python_http_client/client.py 54.36% <50%> (-23.31%) ⬇️
python_http_client/exceptions.py 73.68% <0%> (-23.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9196b9f...5ef47d3. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #111 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   91.46%   91.46%           
=======================================
  Files           6        6           
  Lines         293      293           
=======================================
  Hits          268      268           
  Misses         25       25
Impacted Files Coverage Δ
tests/test_unit.py 99.2% <ø> (ø) ⬆️
tests/test_repofiles.py 100% <ø> (ø) ⬆️
python_http_client/client.py 77.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45c299...ed8b8e2. Read the comment docs.

@vkmrishad
Copy link
Contributor Author

@misterdorm

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 22, 2018
@vkmrishad
Copy link
Contributor Author

@misterdorm
Please add available labels and merge this PR

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty hacktoberfest status: ready for deploy code ready to be released in next deploy and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 30, 2018
@thinkingserious
Copy link
Contributor

Hello @vkmrishad,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit c0d620e into sendgrid:master Oct 30, 2018
@vkmrishad
Copy link
Contributor Author

@thinkingserious @misterdorm
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants