Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial travis config for pypi deployment #102

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

georgeyk
Copy link
Contributor

@georgeyk georgeyk commented Oct 9, 2018

Fixes

#92

Short description of what this PR does:

Adds the initial changes in travis configuration to integrate pypi as discussed in #92

@thinkingserious I'm not sure how I could test this change.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 9, 2018
@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing difficulty: hard fix is hard in difficulty hacktoberfest and removed status: code review request requesting a community code review or review from Twilio labels Oct 12, 2018
@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio status: hacktoberfest approved and removed status: work in progress Twilio or the community is in the process of implementing labels Oct 22, 2018
@thinkingserious
Copy link
Contributor

Hello @georgeyk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious added the type: twilio enhancement feature request on Twilio's roadmap label Oct 22, 2018
@codecov
Copy link

codecov bot commented Oct 30, 2018

Codecov Report

Merging #102 into master will increase coverage by 0.76%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   91.61%   92.37%   +0.76%     
==========================================
  Files           6        6              
  Lines         298      354      +56     
==========================================
+ Hits          273      327      +54     
- Misses         25       27       +2
Impacted Files Coverage Δ
tests/test_unit.py 98.23% <0%> (-0.99%) ⬇️
tests/test_daterange.py 100% <0%> (ø) ⬆️
tests/test_repofiles.py 100% <0%> (ø) ⬆️
python_http_client/__init__.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a3ba0...e09d09a. Read the comment docs.

Copy link
Contributor

@misterdorm misterdorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward enough. I am not super familiar with the PyPi setup, do we need to add credentials in here as secure strings? @thinkingserious do you know?

@thinkingserious
Copy link
Contributor

Hello @georgeyk,

Thanks again for the PR!

You have earned 7 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

@misterdorm misterdorm added status: work in progress Twilio or the community is in the process of implementing and removed status: code review request requesting a community code review or review from Twilio labels Oct 31, 2018
@thinkingserious thinkingserious merged commit fe7c018 into sendgrid:master Nov 14, 2018
@thinkingserious
Copy link
Contributor

Hello @georgeyk,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants