Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Fix "method_complexity" issue in config.py - Fixes #105 #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "method_complexity" issue in config.py - Fixes #105 #115

wants to merge 2 commits into from

Conversation

jlax47
Copy link

@jlax47 jlax47 commented Oct 31, 2017

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Refactor config.py init_environment() to include a second static method for setting the variables to get around the Cognitive Complexity of 6 (exceeds 5 allowed).

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@SendGridDX
Copy link

SendGridDX commented Oct 31, 2017

CLA assistant check
All committers have signed the CLA.

@jlax47 jlax47 changed the title Fixes 105 Fixes #105 Oct 31, 2017
@jlax47 jlax47 changed the title Fixes #105 Fix "method_complexity" issue in config.py - Fixes #105 Oct 31, 2017
@thinkingserious
Copy link
Contributor

@jlax47

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants