Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The use of ExtJS CE is not displayed correctly in the console #330

Open
cstffx opened this issue Apr 22, 2019 · 1 comment
Open

The use of ExtJS CE is not displayed correctly in the console #330

cstffx opened this issue Apr 22, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@cstffx
Copy link

cstffx commented Apr 22, 2019

Sencha does not provide ext-react from its private repository for ExtJS CE users, but since the code in this repository has Apache 2 and MIT licenses, it is technically possible that users using the CE can use ext-react with the ExtJS components to which they have access. However, ext-react-webpack-plugin does not detect correctly when the CE is used and incorrectly shows on the label the use of the commercial version.

I suggest using the variable extPkg in /packages/ext-react-webpack-plugin/src/pluginUtil.js

if (extPkg._resolved == undefined) {
    v.edition = `Commercial`
  }
  else {
    if (-1 == extPkg._resolved.indexOf('community')) {
      v.edition = `Commercial`
    }
    else {
      v.edition = `Community`
    }
}
@branflake2267 branflake2267 added the bug Something isn't working label Apr 23, 2019
@branflake2267
Copy link
Contributor

Thanks for reporting. One of the team leaders will help out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants