test: removed obsolete DropTest::createGraph; added exploit for #114

Author: k00ni

tests/db_adapter_depended/sparql_1_1_tests/DropTest.php

@@ -19,51 +19,6 @@ public function setUp()
         $this->testPref = 'http://www.w3.org/2009/sparql/docs/tests/data-sparql11/drop/manifest#';
     }
 
-    /**
-     * @param string $graphUri
-     * @todo Check that $graphUri is a valid URI
-     * @todo port this functionality to ARC2_Store->query
-     */
-    protected function createGraph($graphUri)
-    {
-        // g2t table
-        if (isset($this->dbConfig['db_table_prefix'])) {
-            $g2t = $this->dbConfig['db_table_prefix'] . '_';
-        } else {
-            $g2t = '';
-        }
-        if (isset($this->dbConfig['store_name'])) {
-            $g2t .= $this->dbConfig['store_name'] . '_';
-        }
-        $g2t .= 'g2t';
-
-        // id2val table
-        if (isset($this->dbConfig['db_table_prefix'])) {
-            $id2val = $this->dbConfig['db_table_prefix'] . '_';
-        } else {
-            $id2val = '';
-        }
-        if (isset($this->dbConfig['store_name'])) {
-            $id2val .= $this->dbConfig['store_name'] . '_';
-        }
-        $id2val .= 'id2val';
-
-        /*
-         * for id2val table
-         */
-        $query = 'INSERT INTO '. $id2val .' (val) VALUES("'. $graphUri .'")';
-        $this->store->getDBObject()->simpleQuery($query);
-        $usedId = $this->store->getDBObject()->getLastInsertId();
-
-        /*
-         * for g2t table
-         */
-        $newIdg2t = 1 + $this->getRowCount($g2t);
-        $query = 'INSERT INTO '. $g2t .' (t, g) VALUES('. $newIdg2t .', '. $usedId .')';
-        $this->store->getDBObject()->simpleQuery($query);
-        $usedId = $this->store->getDBObject()->getLastInsertId();
-    }
-
     /**
      * Helper function to get test query for a given test.
      *
@@ -100,9 +55,6 @@ public function test_delete_graph()
     {
         $graphUri = 'http://example.org/g1';
 
-        // create graph
-        $this->createGraph($graphUri);
-
         $this->store->query('INSERT INTO <'.$graphUri.'> {
             <http://example.org/g1> <http://example.org/name> "G1" ;
                                     <http://example.org/description> "Graph 1" .

tests/db_adapter_depended/store/ARC2_StoreTest.php

@@ -557,6 +557,27 @@ public function testInsertSaftRegressionTest3()
         $this->assertEquals(1, count($res['result']['rows']));
     }
 
+    public function testMultipleInsertQuerysInDifferentGraphs()
+    {
+        $this->fixture->query('INSERT INTO <http://graph1/> {<http://foo/1> <http://foo/2> <http://foo/3> . }');
+        $this->fixture->query('INSERT INTO <http://graph2/> {<http://foo/4> <http://foo/5> <http://foo/6> . }');
+        $this->fixture->query('INSERT INTO <http://graph2/> {<http://foo/1> <http://foo/2> <http://foo/3> . }');
+
+        $res = $this->fixture->query('SELECT * FROM <http://graph1/> WHERE {?s ?p ?o.}');
+        $this->assertEquals(1, count($res['result']['rows']));
+
+        $res = $this->fixture->query('SELECT * FROM <http://graph2/> WHERE {?s ?p ?o.}');
+        $this->assertEquals(1, count($res['result']['rows']));
+
+        $res = $this->fixture->query('SELECT * WHERE {?s ?p ?o.}');
+        $this->assertEquals(3, count($res['result']['rows']));
+
+        $this->markTestSkipped(
+            'Adding the same triple into two graphs does not work.'
+            . PHP_EOL . 'Bug report: https://github.com/semsol/arc2/issues/114'
+        );
+    }
+
     /*
      * Tests for logQuery
      */