Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client credential auth method #164

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Add client credential auth method #164

merged 2 commits into from
Nov 29, 2022

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Nov 28, 2022

This adds a new oidc authentication method to the client and refactors the authentication handling

You can use this authentication mode with

client = weaviate.Client(
        url=URL, auth_client_secret=weaviate.AuthClientCredentials(client_secret=CLIENT_SECRET, scope=SCOPE),
    )

Tested with okta and azure

@dirkkul dirkkul force-pushed the auth_client_credentials branch 4 times, most recently from 5eaa6b2 to a421039 Compare November 28, 2022 15:59
@dirkkul dirkkul requested a review from StefanBogdan November 28, 2022 16:00
@dirkkul dirkkul force-pushed the auth_client_credentials branch from a421039 to d2755d4 Compare November 28, 2022 16:02
mock_tests/test_connection.py Show resolved Hide resolved
weaviate/auth.py Show resolved Hide resolved
@StefanBogdan
Copy link
Member

Do we want to add same test for Google authentication?

@dirkkul
Copy link
Collaborator Author

dirkkul commented Nov 28, 2022

Do we want to add same test for Google authentication

Google sadly doesn't support client credentials. I haven't tested user/pw, but I'll make sure that the next method is supported by google

@dirkkul dirkkul force-pushed the auth_client_credentials branch 2 times, most recently from ebcab1a to e9eab67 Compare November 28, 2022 17:32
@dirkkul dirkkul merged commit 06581d5 into main Nov 29, 2022
@dirkkul dirkkul deleted the auth_client_credentials branch November 29, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants