-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't save text with emoji 😿 #5
Comments
@connor-baer I've been wanting to look into this for a while😉 We'll explore adding support for it👍 |
That's a good Idea/Addition I think Will look into it. Thanks for letting us know 👍 |
Fantastic! 🙌 I did a bit more testing and research. Native Craft fields don't support emoji either. I found this StackExchange answer that's quite insightful, but inconclusive. Since this is foremost an issue with Craft itself, I've filed an issue there as well: craftcms/cms#1627 |
Native rich text fields in Craft 3 now support emoji, it was fixed in craftcms/cms@3c5323e. I guess this could be inspiration for Doxter? Changing the code at
...allows a Doxter field containing emoji to be saved. However, the emoji is then returned as an HTML entity, e.g. 🙌 → That's how far my limited PHP skills got me. 😬 |
@connor-baer Thanks a bunch for the investigative work and your notes, really helpful. We'll update you when we decide on plan of attack! |
@connor-baer Thanks to your research, we were able to make progress on this front. We believe we have a possible solution for Doxter to be able to save emojis (and any other unicode chars), render properly when markdown is parsed, and render properly within the editor. This last part is the trickiest (as you pointed out above) and the solution would be to decode those html entities into their corresponding emoji character. However, due to the nature of the Doxter editor having to allow plain text (markdown) and also arbitrary html, we have to be very selective about where to apply the decoding. I'll work with my team and get a solution in place and will update you when we have something that works. |
@selvinortiz Glad my contribution was helpful! I'm pleasantly surprised how quickly you're working on a solution! Thank you! |
Tested and it works. 🎉 Thank you for implementing this! |
The Doxter field does not support text that contains emoji.
When attempting to save the entry, the following error is returned:
Any chance you could add support for emoji in the Doxter field? Pretty please? 🙏
The text was updated successfully, but these errors were encountered: