Skip to content

Conversation

@remicolin
Copy link
Collaborator

@remicolin remicolin commented Oct 19, 2025

Summary by CodeRabbit

  • Chores

    • Updated application version to 2.7.1
    • Incremented iOS build number
  • Bug Fixes

    • Enhanced passport signature validation with improved fallback algorithm handling

transphorm and others added 30 commits September 30, 2025 15:40
chore: fix mobile deploy pipelines v2.6.8 rd2 (#1159)
chore: fix build version numbers for v2.6.8
chore: address staging branch issues pr #1169 (#1178)
…h-id-picker

chore: update staging; release id picker `v.2.6.8`
* add only triggers

* tweak release

* formatting
…nimations-fix

release: iOS bugfix build v2.6.9
)

* chore: bump iOS build number to 179

* fix: use PR source commit for deployment to get correct version.json

When deploying from a PR merge (e.g., dev → staging), now uses the source
branch's commit instead of always checking out staging. This ensures
version.json has the correct bumped build number from the previous
deployment's PR back to dev, preventing 'build number already exists' errors.

* downgrade to match store

* fix: use merge_commit_sha instead of head.sha for deployments

Use github.event.pull_request.merge_commit_sha instead of head.sha to ensure
we deploy exactly what landed on staging after the merge, not just the source
branch state. This correctly handles:
- Conflict resolutions made during merge
- Any staging-only changes
- The actual state of staging post-merge

The merge commit still includes the updated version.json from the source
branch (e.g., dev), so build numbers remain correct while ensuring we deploy
and tag the true staging state.

Co-authored-by: CodeRabbit <[email protected]>

---------

Co-authored-by: CodeRabbit <[email protected]>
…version0v269

fix build version for v2.6.9
* refine mobile deploy auto pr logic

* remove env check

* fix get-version
…1244)

* bump version to match staging

* save wip

* deploy fixes

* fix version setting

* update version logic

* fix version pr

* increase timeout to 2 hours

* pr logic tweaks

* fix script

* fix script path

* add comments and update logic to test from feature branch

* fix build path

* fix version input error

* fix pulling version

* add skip-deploy lable

* address cr concners
staging: test mobile deploy auto pull request (#1234)
…-to-staging

staging: update release calendar logic (#1256)
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 19, 2025

Caution

Review failed

The pull request is closed.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

This PR bumps the app version from 2.7.0 to 2.7.1 across iOS and package manifests, increments the iOS build number from 180 to 181, and adds an RSA hash-algorithm fallback to the brute-force passport signature parsing utility.

Changes

Cohort / File(s) Change Summary
iOS and Package Versioning
app/ios/OpenPassport/Info.plist, app/ios/Self.xcodeproj/project.pbxproj, app/package.json, app/version.json
Version bumped from 2.7.0 to 2.7.1; iOS build number incremented from 180 to 181 in Debug and Release configurations
Passport Signature Parsing
common/src/utils/passports/passport_parsing/brutForcePassportSignature.ts
Added RSA hash-algorithm fallback in brutforceSignatureAlgorithm; after rsapss loop, now calls brutforceHashAlgorithm with 'rsa' parameter and returns config with signatureAlgorithm 'rsa', discovered hashAlgorithm, and saltLength 0 if hash found

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

The changes consist primarily of straightforward version bumps across configuration files, with a single logic addition that introduces a conditional fallback path—routine and low-complexity modifications.

Possibly related PRs

Poem

🔑 From 2.7.0 to 2.7.1, a journey small,
Build 180 → 181, ascending all,
RSA fallback whispers secure and strong,
Signatures parse where they once went wrong. 🛡️

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch staging

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 14b7583 and cb2c5dd.

📒 Files selected for processing (5)
  • app/ios/OpenPassport/Info.plist (1 hunks)
  • app/ios/Self.xcodeproj/project.pbxproj (2 hunks)
  • app/package.json (1 hunks)
  • app/version.json (1 hunks)
  • common/src/utils/passports/passport_parsing/brutForcePassportSignature.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on November 17

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

hashAlgorithm: hashAlgorithm,
saltLength: 0,
};
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redundant RSA Signature Verification

The new RSA signature verification block (lines 43-50) duplicates an earlier check. Its placement after the RSA-PSS loop means it's either unreachable if RSA verification succeeded, or it's a redundant retry that can lead to inconsistent behavior and mask signature algorithm mismatches.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants