-
Notifications
You must be signed in to change notification settings - Fork 181
Staging #1305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chore: fix mobile deploy pipelines v2.6.8 rd2 (#1159)
chore: fix build version numbers for v2.6.8
release: v2.6.8 rd3
…h-id-picker chore: update staging; release id picker `v.2.6.8`
* add only triggers * tweak release * formatting
…nimations-fix release: iOS bugfix build v2.6.9
) * chore: bump iOS build number to 179 * fix: use PR source commit for deployment to get correct version.json When deploying from a PR merge (e.g., dev → staging), now uses the source branch's commit instead of always checking out staging. This ensures version.json has the correct bumped build number from the previous deployment's PR back to dev, preventing 'build number already exists' errors. * downgrade to match store * fix: use merge_commit_sha instead of head.sha for deployments Use github.event.pull_request.merge_commit_sha instead of head.sha to ensure we deploy exactly what landed on staging after the merge, not just the source branch state. This correctly handles: - Conflict resolutions made during merge - Any staging-only changes - The actual state of staging post-merge The merge commit still includes the updated version.json from the source branch (e.g., dev), so build numbers remain correct while ensuring we deploy and tag the true staging state. Co-authored-by: CodeRabbit <[email protected]> --------- Co-authored-by: CodeRabbit <[email protected]>
chore: fix mobile auto deploy v2.6.9 rd2
…version0v269 fix build version for v2.6.9
chore: bump iOS build for 2.6.9
* refine mobile deploy auto pr logic * remove env check * fix get-version
…1244) * bump version to match staging * save wip * deploy fixes * fix version setting * update version logic * fix version pr * increase timeout to 2 hours * pr logic tweaks * fix script * fix script path * add comments and update logic to test from feature branch * fix build path * fix version input error * fix pulling version * add skip-deploy lable * address cr concners
staging: test mobile deploy auto pull request (#1234)
…-to-staging staging: update release calendar logic (#1256)
allow staging pull requests into main
Release to Staging - 2025-10-10
Release to Staging - 2.7.0 rd2
Release to Staging - 2025-10-12 - v2.7.0
Add RSA hash algorithm detection in passport parsing
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis PR bumps the app version from 2.7.0 to 2.7.1 across iOS and package manifests, increments the iOS build number from 180 to 181, and adds an RSA hash-algorithm fallback to the brute-force passport signature parsing utility. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes The changes consist primarily of straightforward version bumps across configuration files, with a single logic addition that introduces a conditional fallback path—routine and low-complexity modifications. Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on November 17
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| hashAlgorithm: hashAlgorithm, | ||
| saltLength: 0, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Redundant RSA Signature Verification
The new RSA signature verification block (lines 43-50) duplicates an earlier check. Its placement after the RSA-PSS loop means it's either unreachable if RSA verification succeeded, or it's a redundant retry that can lead to inconsistent behavior and mask signature algorithm mismatches.
Summary by CodeRabbit
Chores
Bug Fixes