-
Notifications
You must be signed in to change notification settings - Fork 181
fix: update Lottie component usage in QR code SDK #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Walkthrough
Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (2)**/*.{js,ts,tsx,jsx,sol,nr}📄 CodeRabbit inference engine (.cursorrules)
Files:
sdk/**/*.{ts,tsx,js,jsx}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📚 Learning: 2025-08-26T14:49:11.190ZApplied to files:
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
To clarify the CodeRabbit summary: SelfQRcodeWrapper was already a named export; this PR just updates the README to reflect that. |
I noticed that the
SelfQRcodecomponent's render method returnsundefinedwhen it reached thePROOF_VERIFIEDorPROOF_GENERATION_FAILEDstates. Locally patching the component to useLottieinstead ofLottie.defaultfixed the issue.Summary by CodeRabbit
Refactor
Documentation