remove lazy loading #1018
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| // SPDX-FileCopyrightText: 2025 Social Connect Labs, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE. | ||
|
|
||
| import React, { createElement, forwardRef } from 'react'; | ||
| import { Platform } from 'react-native'; | ||
|
|
||
| // Platform-specific SvgXml component | ||
| const SvgXmlWrapper = forwardRef< | ||
| HTMLDivElement | SVGSVGElement, | ||
| { | ||
| xml: string; | ||
| width?: number; | ||
| height?: number; | ||
| style?: React.CSSProperties; | ||
| } | ||
| >(({ xml, width, height, style, ...props }, ref) => { | ||
| if (Platform.OS === 'web') { | ||
| // Use our mock for web | ||
| return createElement('div', { | ||
| ref, | ||
| style: { | ||
| width: width || 'auto', | ||
| height: height || 'auto', | ||
| display: 'inline-block', | ||
| ...style, | ||
| }, | ||
| dangerouslySetInnerHTML: { __html: xml }, | ||
| ...props, | ||
| }); | ||
| } | ||
|
||
|
|
||
| // Use the real SvgXml for native platforms | ||
| // eslint-disable-next-line @typescript-eslint/no-require-imports | ||
| const { SvgXml } = require('react-native-svg'); | ||
| return ( | ||
| <SvgXml xml={xml} width={width} height={height} style={style} {...props} /> | ||
| ); | ||
| }); | ||
|
|
||
| SvgXmlWrapper.displayName = 'SvgXmlWrapper'; | ||
|
|
||
| export { SvgXmlWrapper as SvgXml }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-FileCopyrightText: 2025 Social Connect Labs, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE. | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| // Mock BlurView component for web builds | ||
| export const BlurView = React.forwardRef< | ||
| HTMLDivElement, | ||
| React.HTMLAttributes<HTMLDivElement> & { | ||
| blurType?: string; | ||
| blurAmount?: number; | ||
| reducedTransparencyFallbackColor?: string; | ||
| } | ||
| >(({ children, style, ...props }, ref) => { | ||
| return React.createElement( | ||
| 'div', | ||
| { | ||
| ref, | ||
| style: { | ||
| backgroundColor: 'rgba(255, 255, 255, 0.1)', | ||
| backdropFilter: 'blur(10px)', | ||
| ...style, | ||
| }, | ||
| ...props, | ||
| }, | ||
| children, | ||
| ); | ||
| }); | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| BlurView.displayName = 'BlurView'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| // SPDX-FileCopyrightText: 2025 Social Connect Labs, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE. | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| export const Circle = React.forwardRef< | ||
| SVGCircleElement, | ||
| React.SVGProps<SVGCircleElement> | ||
| >((props, ref) => { | ||
| return React.createElement('circle', { ref, ...props }); | ||
| }); | ||
|
|
||
| Circle.displayName = 'Circle'; | ||
|
|
||
| export const Path = React.forwardRef< | ||
| SVGPathElement, | ||
| React.SVGProps<SVGPathElement> | ||
| >((props, ref) => { | ||
| return React.createElement('path', { ref, ...props }); | ||
| }); | ||
|
|
||
| Path.displayName = 'Path'; | ||
|
|
||
| export const Rect = React.forwardRef< | ||
| SVGRectElement, | ||
| React.SVGProps<SVGRectElement> | ||
| >((props, ref) => { | ||
| return React.createElement('rect', { ref, ...props }); | ||
| }); | ||
|
|
||
| Rect.displayName = 'Rect'; | ||
|
|
||
| // Re-export other common SVG components that might be used | ||
| export const Svg = React.forwardRef< | ||
| SVGSVGElement, | ||
| React.SVGProps<SVGSVGElement> | ||
| >((props, ref) => { | ||
| return React.createElement('svg', { ref, ...props }); | ||
| }); | ||
|
|
||
| Svg.displayName = 'Svg'; | ||
|
|
||
| // Mock SvgXml component for web builds | ||
| export const SvgXml = React.forwardRef< | ||
| HTMLDivElement, | ||
| { | ||
| xml: string; | ||
| width?: number; | ||
| height?: number; | ||
| style?: React.CSSProperties; | ||
| } | ||
| >(({ xml, width, height, style, ...props }, ref) => { | ||
| return React.createElement('div', { | ||
| ref, | ||
| style: { | ||
| width: width || 'auto', | ||
| height: height || 'auto', | ||
| display: 'inline-block', | ||
| ...style, | ||
| }, | ||
| dangerouslySetInnerHTML: { __html: xml }, | ||
| ...props, | ||
| }); | ||
| }); | ||
|
|
||
| SvgXml.displayName = 'SvgXml'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Replace direct cache usage with a composite cache-built-deps action (aligns with repo policy).
This block is fine for diagnostics, but the surrounding restore/save steps use actions/cache directly, which violates our workflow guideline to use shared composite caching actions from .github/actions. Please introduce a ./.github/actions/cache-built-deps composite that wraps restore/save for common/dist and packages/mobile-sdk-alpha/dist and exposes cache-hit, then consume it here and in all jobs (build-deps, test, build-ios, build-android). Do the same for Xcode caches via a cache-xcode composite to remove raw actions/cache calls.
Example composite (new file):
Then replace all “Restore/Save Built Dependencies” pairs with a single:
🤖 Prompt for AI Agents